ENH/TST: Add quantile & mode tests for ArrowExtensionArray #47744
Conversation
mroeschke
commented
Jul 15, 2022
•
mroeschke
commented
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
mroeschke
added
Testing
| msg = "Falling back on a non-pyarrow code path which may decrease performance." | ||
| msg = ( | ||
| "Falling back on a non-pyarrow code path which may decrease performance or " | ||
| "not be fully compatible with pyarrow." |
There was a problem hiding this comment.
Is there a specific reason for adding this additional sentence?
(since it is so generic, it's also not that useful / potentially confusing I think)
There was a problem hiding this comment.
I also wanted to convey in this message that a user may get incorrect results if falling back.
e.g. A user's code could fall back to using ExtensionArray._mode/_quantile which may have some numpy-based assumptions that may fail when passing arrow (or arrow transformed) data.
There was a problem hiding this comment.
If we know (think?) that a certain fallback can give incorrect results, can we rather have it error in that case? (for that specific function)
There was a problem hiding this comment.
Yeah that's a good point. Okay I'll leave this message alone, and raise a NotImplementedError for the associated case (mode/quantile)
|
32-bit test failing? |
Unrelated, but addressed at #47803 |
|
can u rebase |
|
Rebased |
