-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Updating some capitalization in doc/source/user_guide #32550 #47732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SomtochiUmeh
commented
Jul 15, 2022
- contributes to Fix capitalization among headings in documentation files #32550
- I left RadViz, SparseArray, SparseDtype, and PandasObject as is
doc/source/user_guide/timedeltas.rst
Outdated
@@ -67,7 +67,7 @@ Further, operations among the scalars yield another scalar ``Timedelta``. | |||
"00:00:00.000123" | |||
) | |||
|
|||
to_timedelta | |||
To_timedelta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would leave this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
doc/source/user_guide/sparse.rst
Outdated
@@ -266,7 +266,7 @@ have no replacement. | |||
|
|||
.. _sparse.scipysparse: | |||
|
|||
Interaction with scipy.sparse | |||
Interaction with SciPy.sparse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave this one (could make it italitc or code style though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Added a few questions
@@ -874,7 +874,7 @@ is already ``False``): | |||
True & pd.NA | |||
|
|||
|
|||
``NA`` in a boolean context | |||
``NA`` in a Boolean context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"boolean" doesn't refer to a Boolean
class, so it can be left lower case I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright.
doc/source/user_guide/sparse.rst
Outdated
@@ -266,7 +266,7 @@ have no replacement. | |||
|
|||
.. _sparse.scipysparse: | |||
|
|||
Interaction with scipy.sparse | |||
Interaction with *scipy.sparse* | |||
----------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also adapt the underline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand now; I'm meant to extend the underline to be the same length as the text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed
doc/source/user_guide/timeseries.rst
Outdated
@@ -3,7 +3,7 @@ | |||
{{ header }} | |||
|
|||
******************************** | |||
Time series / date functionality | |||
Time Series / date functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is not a single word, is there a specific reason to capitalize Series?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. I'll correct that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @SomtochiUmeh