Skip to content

ENH/TST: Add Reduction tests for ArrowExtensionArray #47730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 22, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jul 15, 2022

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Arrow pyarrow functionality labels Jul 15, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 15, 2022
@jreback
Copy link
Contributor

jreback commented Jul 21, 2022

32-bit tests ok?

@mroeschke
Copy link
Member Author

32-bit tests ok?

Yeah unrelated, but addressed at #47803

@@ -628,6 +628,69 @@ def _concat_same_type(
arr = pa.chunked_array(chunks)
return cls(arr)

def _reduce(self, name: str, *, skipna: bool = True, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could type the return

@jreback jreback merged commit bedd8f0 into pandas-dev:main Jul 22, 2022
@mroeschke mroeschke deleted the arrow/reduction branch July 22, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants