TYP: freq and na_value #47729
Merged
TYP: freq and na_value #47729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jul 15, 2022
pandas/core/arrays/datetimes.py
Outdated
| cls, values: np.ndarray, freq: BaseOffset | None = None, dtype=DT64NS_DTYPE | ||
| cls, | ||
| values: np.ndarray, | ||
| freq: str | BaseOffset | lib.NoDefault | None = None, |
There was a problem hiding this comment.
@jbrockmendel should the caller ensure the freq is not a string when calling _simple_new?
There was a problem hiding this comment.
this should be BaseOffset | None
There was a problem hiding this comment.
Thank you, I changed it!
mroeschke
reviewed
Jul 18, 2022
mroeschke
approved these changes
Jul 18, 2022
|
Thanks @twoertwein |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type annotations are only related by having
lib.no_defaultas a default value (pyright then assumes that their type islib.NoDefault).