Skip to content

TST: avoid sort when concat int-index Dataframes with sort=False #47685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2022
Merged

TST: avoid sort when concat int-index Dataframes with sort=False #47685

merged 3 commits into from
Jul 12, 2022

Conversation

GYHHAHA
Copy link
Contributor

@GYHHAHA GYHHAHA commented Jul 12, 2022 •
edited
Loading

This issue may have been fixed by #36299. Add the test and close.

@pep8speaks
Copy link

pep8speaks commented Jul 12, 2022 •
edited
Loading

Hello @GYHHAHA! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-07-12 19:20:34 UTC

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jul 12, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 12, 2022
@mroeschke mroeschke merged commit c711be0 into pandas-dev:main Jul 12, 2022
@mroeschke
Copy link
Member

Thanks @GYHHAHA

@GYHHAHA GYHHAHA deleted the patch-1 branch July 13, 2022 01:23
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@GYHHAHA @yehoshuadimarsky
TST: avoid sort when concat int-index Dataframes with sort=False (pan…
b71a017 
…das-dev#47685)

* Update test_sort.py

* Update test_sort.py

* add assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: Concat automatically sorts index when axis=1
3 participants
@GYHHAHA @pep8speaks @mroeschke