Bug fix using GroupBy.resample produces inconsistent behavior when calling it over empty df #47705 #47672
Conversation
|
Hello @ahmedibrhm! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-08-15 17:40:17 UTC |
ahmedibrhm
changed the title
|
@mroeschke it's ready for another look if you wanna review again |
|
|
||
|
|
||
| @pytest.mark.parametrize("keys", [["a"], ["a", "b"]]) | ||
| def test_resample_empty_Dataframe(keys): |
There was a problem hiding this comment.
Is it possible to combine this with test_empty above using pytest.mark.parametrize?
| @@ -514,11 +514,20 @@ def _wrap_result(self, result): | |||
| """ | |||
| Potentially wrap any results. | |||
| """ | |||
| obj = self.obj | |||
There was a problem hiding this comment.
Could you add # GH 47705 here?
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
There was a problem hiding this comment.
One outstanding question about combining tests. @ahmedibrhm - can you address this (it may not be feasible to combine the tests), move the whatsnew note to 1.6.0, and merge main.
|
@rhshadrach sorry for the delay I was traveling and couldn't check that at all. It's hard to combine the tests because one test has the name of the column "date". So it won't be feasible to construct the expected one. |
|
No problem @ahmedibrhm! Looks like the whatsnew note got dropped - can you add that back in to 1.6.0. |
|
@rhshadrach how about now |
|
Thanks @ahmedibrhm |
…lling it over empty df pandas-dev#47705 (pandas-dev#47672) * DOC pandas-dev#45443 edited the documentation of where/mask functions * DOC pandas-dev#45443 edited the documentation of where/mask functions * Update generic.py * Bug 43767 fix * fixing lines doc * visual indent * visual indent * indentation * grouby.resample bug * groubby.sample * syntax * syntax * syntax * syntax * what's new * flake8 error * pytest * blank line * editting resample * editting resample * syntax * syntax * syntax * space * space * space * inplace * spelling * test * test resampler * tests * tests * Update resample.py * Update resample.py * Update resample.py * Update v1.6.0.rst
doc/source/whatsnew/v1.5.0.rstfile if fixing a bug or adding a new feature.