-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
SAS7BDAT parser: Improve subheader lookup performance #47656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test failure seems unrelated to this PR but still worth fixing. I'll need some guidance here. The problem is that we don't have an explicit |
@mroeschke any pointers for the failing test (see comment above)? |
Sorry, I'm not too familiar with this part of the codebase. It looks like it's using the shared file handling code, but not sure if the one of the sas is still keeping a reference to the file handle somewhere? |
Bug in |
76acac3
to
dbaf39b
Compare
@mroeschke tests fixed, should be good to review now. |
Thanks @jonashaag |
* SAS7BDAT parser: Improve subheader lookup performance * Fix ssize_t type * Update _sas.pyi * Lint
Avoid constructing
_SubheaderPointer
objects and make dictionary lookups in C rather than in Python.Speedup relative to current
main
:Will extend what's new from #47404 once that's merged.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.