Skip to content

Fixed mypy errors in frequencies.py #47644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 8, 2022
Merged

Conversation

srotondo
Copy link
Contributor

@srotondo srotondo commented Jul 8, 2022

@srotondo
Copy link
Contributor Author

srotondo commented Jul 8, 2022

Shoot, looks like I accidentally left a change from one of my previous PRs in here, I'll fix that

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mroeschke mroeschke added this to the 1.5 milestone Jul 8, 2022
@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Jul 8, 2022
@mroeschke mroeschke merged commit cef9aad into pandas-dev:main Jul 8, 2022
@mroeschke
Copy link
Member

Thanks @srotondo

Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be fine with keeping it as-is and waiting for python/typeshed#8219 allowing any object in .get

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* TST: Added test for consistent type with unique agg pandas-dev#22558

* TST: Added test for consistent type with unique agg pandas-dev#22558

* TST: Moved and restructured test pandas-dev#22558

* TYP: Fixed mypy issues in frequencies

* TYP: Removed accidental inclusion

Co-authored-by: Steven Rotondo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants