-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fixed mypy errors in frequencies.py #47644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Shoot, looks like I accidentally left a change from one of my previous PRs in here, I'll fix that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @srotondo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also be fine with keeping it as-is and waiting for python/typeshed#8219 allowing any object in .get
* TST: Added test for consistent type with unique agg pandas-dev#22558 * TST: Added test for consistent type with unique agg pandas-dev#22558 * TST: Moved and restructured test pandas-dev#22558 * TYP: Fixed mypy issues in frequencies * TYP: Removed accidental inclusion Co-authored-by: Steven Rotondo <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.