Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: add result_names argument to DataFrame.compare #44354 #47643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add result_names argument to DataFrame.compare #44354 #47643
Changes from 26 commits
54c5068
2951fb1
6335204
2245def
330eda8
8afd6a1
edc9ff4
a326359
d9c4ca9
1c54472
ad7fb76
4d34821
8fb6aa2
1e33dea
ae6c75a
ee10dd3
077d274
3b2ef9e
d0289e5
bd45e06
a13b319
f32d7cf
6396583
e754e15
8f67c9f
fa4e26b
580773d
15a9a57
a4fca56
a468714
bc209bb
ff014e3
32d1c5e
0daa3e8
be1a9ad
9cb23b8
7ad93e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should call this
names
or mayberesult_names
as suffixes implies we are appending these to something (ala merge)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback Sorry, I didn't see the comment.
I guess suffix should be used because to some extent the result will be merged. What I mean is that the comparison will be one block representing the different parts of the two dataframes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see your point but result names will mean that the result will have names. like we have an output which will have multiple names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback I edited the name of the argument