Skip to content

TST: adding test for multiindex nunique raising not implemnted error #47638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2022
Merged

TST: adding test for multiindex nunique raising not implemnted error #47638

merged 3 commits into from
Jul 8, 2022

Conversation

noatamir
Copy link
Member

@noatamir noatamir commented Jul 8, 2022

@noatamir noatamir marked this pull request as ready for review July 8, 2022 11:50
@jreback jreback added this to the 1.5 milestone Jul 8, 2022
@jreback jreback added Testing pandas testing functions or related to the test suite MultiIndex labels Jul 8, 2022
jreback
jreback reviewed Jul 8, 2022
View reviewed changes
pandas/tests/indexing/multiindex/test_multiindex.py Outdated
@@ -214,6 +214,11 @@ def test_subtracting_two_series_with_unordered_index_and_all_nan_index(
tm.assert_series_equal(result[0], a_series_expected)
tm.assert_series_equal(result[1], b_series_expected)

def test_nunique_raises_not_implemented_error(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the test name to: test_nunique_smoke as will be indicative here

@mroeschke mroeschke merged commit 16e9b1e into pandas-dev:main Jul 8, 2022
@mroeschke
Copy link
Member

Thanks @noatamir

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@noatamir @yehoshuadimarsky
TST: adding test for multiindex nunique raising not implemnted error (p…
83b5c98 
…andas-dev#47638)

* TST: adding test for multiindex nunique raising not implemnted error

* renamed test
@noatamir noatamir deleted the multiindex-NotImplementedError-test branch October 20, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
MultiIndex Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: Multiindex.nunique raises NotImplementedError
3 participants
@noatamir @mroeschke @jreback