Skip to content

DOC: fixing override of built-in functions in docs #47632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

DOC: fixing override of built-in functions in docs #47632

wants to merge 2 commits into from

Conversation

Transurgeon
Copy link

@Transurgeon Transurgeon commented Jul 8, 2022

@@ -133,8 +133,8 @@ with a combination of the ``iloc`` indexer attribute and ``numpy.r_``.

named = list("abcdefg")
n = 30
columns = named + np.arange(len(named), n).tolist()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

columns is not a built-in function. what are you trying to do here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I am sorry for the mistake. I explained my reasoning in this issue

Could you take a look at it?

Also I was wondering if it was just this file ("comparison_with_r") that was wrong or all of them?

Thanks for the feedback

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on the issue

@mroeschke
Copy link
Member

Thanks for the pull request, but agreed with @phofl's reasoning and columns naming should remain here (we used this naming convention in the code base).

Since the original issue was addressed by #47631 closing as a duplicate, but happy to have a contribution to any of the other documentation issues

@mroeschke mroeschke closed this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: sample codes should not override Python built-in functions
3 participants