Skip to content

BUG: using read_xml with iterparse and names will ignore duplicate values #47630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

BUG: using read_xml with iterparse and names will ignore duplicate values #47630

merged 1 commit into from
Jul 8, 2022

Conversation

ParfaitG
Copy link
Contributor

@ParfaitG ParfaitG commented Jul 8, 2022

@jreback jreback added Bug IO XML read_xml, to_xml labels Jul 8, 2022
@jreback jreback added this to the 1.5 milestone Jul 8, 2022
jreback
jreback reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew note for this, ping on green.

@ParfaitG
Copy link
Contributor Author

ParfaitG commented Jul 8, 2022

@jreback - Since the iterparse is a new, unreleased IO XML feature for 1.5, I was advised by @mroeschke on a related fix that a whatsnew note was not needed. The OP of bug was using a dev version of pandas.

@jreback
Copy link
Contributor

jreback commented Jul 8, 2022

got it (could add this PR number alongside the original note as well) but nbd

@mroeschke mroeschke merged commit 3adfcff into pandas-dev:main Jul 8, 2022
@mroeschke
Copy link
Member

Thanks @ParfaitG. Yeah if you have a follow up PR in mind, adding an additional :issue:`47630` to the 1.5.0 whatsnew note related to this feature would be good

@ParfaitG ParfaitG deleted the iterparse_repeats branch July 9, 2022 00:28
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@ParfaitG @yehoshuadimarsky
BUG: using read_xml with iterparse and names will ignore duplicate va…
f19c23d 
…lues (pandas-dev#47630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug IO XML read_xml, to_xml
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: using read_xml with iterparse and names will ignore duplicate values
3 participants
@ParfaitG @jreback @mroeschke