BUG: boolean indexer with NA raising when reindex is necessary #47623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jul 7, 2022
pandas/core/indexing.py
Outdated
| @@ -2531,6 +2532,9 @@ def check_bool_indexer(index: Index, key) -> np.ndarray: | |||
| """ | |||
| result = key | |||
| if isinstance(key, ABCSeries) and not key.index.equals(index): | |||
| if is_extension_array_dtype(result): | |||
There was a problem hiding this comment.
I think checking the indexer approach may be more robust here instead. Would this hit 3rd party EA dtypes and _mask may not be defined?
There was a problem hiding this comment.
Not sure if this hit in a code path where ExtensionDtype._is_boolean = True
There was a problem hiding this comment.
Also much more performant to check result.dtype than just result
mroeschke
added
Indexing
mroeschke
reviewed
Jul 7, 2022
mroeschke
approved these changes
Jul 8, 2022
|
thanks @phofl |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.There are multiple options how to solve this. Alternatively, we could get the indexeer for the reindexing operation and check for -1 instead of filling the NAs