CLN: Add tets and fix docstring for concat with sort=True and outer join #47612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
changed the title
mroeschke
approved these changes
Jul 7, 2022
mroeschke
added
Testing
|
Thanks @phofl |
| @@ -233,6 +233,7 @@ def _unique_indices(inds, dtype) -> Index: | |||
| Parameters | |||
| ---------- | |||
| inds : list of Index or list objects | |||
| dtype : dtype to set for the resulting Index | |||
There was a problem hiding this comment.
above, it still says The final dtype is inferred.
Is this still true? It is a positional arg and not an optional kwarg, but we can explicitly pass None to get inference?
There was a problem hiding this comment.
Sorry, yeah if None is passed then we infer, should update docstring to reflect this
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…oin (pandas-dev#47612) Add tets and fix docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @simonjayhawkins
Added a couple of tests and fixed the docstring