CI: flake8-pyi #47595
CI: flake8-pyi #47595
Conversation
| @@ -229,3 +229,11 @@ repos: | |||
| entry: python scripts/validate_min_versions_in_sync.py | |||
| language: python | |||
| files: ^(ci/deps/actions-.*-minimum_versions\.yaml|pandas/compat/_optional\.py)$ | |||
| - id: flake8-pyi | |||
| name: flake8-pyi | |||
| entry: flake8 --extend-ignore=E301,E302,E305,E701,E704 | |||
There was a problem hiding this comment.
flake8 doesn't like black's formatting in pyi files
| # Use typing_extensions.TypeAlias for type aliases | ||
| Y026, | ||
| # Use "collections.abc.*" instead of "typing.*" (PEP 585 syntax) | ||
| Y027 |
There was a problem hiding this comment.
Y002: we have one if TYPE_CHECKING, without it mypy cannot infer some types (too many cyclic dependencies or does it hide actual errors?)
Y019: pandas does not (explicitly) depend on typeshed/typing_extension
Y021: some files have notes on how the cython and python types relate to each other
Y026: pandas does not (explicitly) depend on typing_extension
Y027: let's wait until we also do that change for the in-line annotations
| entry: flake8 --extend-ignore=E301,E302,E305,E701,E704 | ||
| types: [pyi] | ||
| language: python | ||
| additional_dependencies: |
There was a problem hiding this comment.
Could these be added to flake8_dependencies in the flake8 block above and then this line changed to additional_dependencies: *flake8_dependencies?
There was a problem hiding this comment.
I first tried to add flake8-pyi to all the other flake8 plugins but the issue is that we need different ignores for pyi files than for normal py files.
I think flake8 supports file-specific ignores. If they support something along the lines *.pyi: E301,E302,E305,E701,E704 that would be the best approach. I'll look into that later today.
There was a problem hiding this comment.
Thanks. That can be a followup PR if it works.
|
Thanks @twoertwein |
No description provided.