TST: Test aggregate with list values #25581 #47559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jul 1, 2022
phofl
reviewed
Jul 2, 2022
|
|
||
| def test_agg_of_list(): | ||
| # GH#25581 | ||
| df1 = DataFrame([[20, "A"], [20, "B"], [30, "C"]]) |
There was a problem hiding this comment.
Could you add the other cases from the issue too?
There was a problem hiding this comment.
From the issue there are 3 other test cases than the one I originally added. I can add 2 of them, but the final test case still fails on the master with a different error message than in 1.4.1.
jreback
added
Testing
jreback
reviewed
Jul 3, 2022
| @@ -1413,3 +1413,14 @@ def test_multi_axis_1_raises(func): | |||
| gb = df.groupby("a", axis=1) | |||
| with pytest.raises(NotImplementedError, match="axis other than 0 is not supported"): | |||
| gb.agg(func) | |||
|
|
|||
|
|
|||
| def test_agg_of_list(): | |||
There was a problem hiding this comment.
can you add mode in the test name as well
mroeschke
reviewed
Jul 5, 2022
mroeschke
approved these changes
Jul 5, 2022
|
Thanks @srotondo |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TST: Test aggregate with list values pandas-dev#25581 * TST: Fixed PEP 8 warnings pandas-dev#25581 * TST: Fixed Flake8 Error pandas-dev#25581 * TST: Added more test cases pandas-dev#25581 * TST: Changed broken test to xfail pandas-dev#25581 Co-authored-by: Steven Rotondo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.