Skip to content

REF: Reduce duplicative methods between XML parser classes #47553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2022
Merged

REF: Reduce duplicative methods between XML parser classes #47553

merged 3 commits into from
Jul 1, 2022

Conversation

ParfaitG
Copy link
Contributor

@ParfaitG ParfaitG added Refactor Internal refactoring of code IO XML read_xml, to_xml labels Jun 30, 2022
mroeschke
mroeschke reviewed Jun 30, 2022
View reviewed changes
mroeschke
mroeschke reviewed Jun 30, 2022
View reviewed changes
@mroeschke mroeschke modified the milestone: 1.5 Jun 30, 2022
@mroeschke mroeschke merged commit ebc96ae into pandas-dev:main Jul 1, 2022
@mroeschke
Copy link
Member

Thanks @ParfaitG

@ParfaitG ParfaitG deleted the xml_refactor branch July 1, 2022 18:59
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@ParfaitG @yehoshuadimarsky
REF: Reduce duplicative methods between XML parser classes (pandas-de…
9e54804 
…v#47553)

* REF: Reduce duplicative methods between XML parser classes

* Add typing to base class methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
IO XML read_xml, to_xml Refactor Internal refactoring of code
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ParfaitG @mroeschke