-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Add information about StyleFrame, to format Excel output #47533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pandas/core/generic.py
Outdated
@@ -2189,6 +2189,9 @@ def to_excel( | |||
Once a workbook has been saved it is not possible to write further | |||
data without rewriting the whole workbook. | |||
|
|||
If you'd like to be more flexible with the output formatting, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in #47525 (comment), you can update the ecosystem docs in doc/source/ecosystem.rst
to mention StyleFrame and then use a Sphix reference to mention there are ecosystem packages to help with output formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, tahnks. I added the package to the ecosystem doc and used a Sphinx reference in the docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like StyleFrame
needs to be referenced in that doc somewhere
…e in to_excel docstring.
Thanks @INDIG0N. The idea would be to add a section for I personally don't see how we can add a useful note to the You can see other entries in Ecosystem to see what's expected to be added. |
Makes sense, I'll go ahead and take out the changes to the docstring. |
The
I think if we add a third party library to ecosystem, it would be worthwhile stating what it can do, extra, that pandas cannot. In particular that warrants the use of the phrase "easier styling", which, currently, I am skeptical of. |
I'm not aware of pandas providing much functionality for exporting an excel file with colors, number formats... I agree that just saying "easier styling" can be improved, but I think it's worth having it in our ecosystem. @INDIG0N do you mind expanding the description a bit to make it clear for readers what And sorry it's taking quite long to review this PR. |
Exporting from Styler to Excel is documented in the Table Visualization user guide. It includes coloring, borders and fonts for headers, index and data cells. It can also write the excel number format directly. The conditional formatting tools are all directly tied into Styler. Im not against including StyleFrame but I reiterate that if it can only replicate what Styler can already do there is no point in its inclusion. I would like to kmow more about its additional features. |
Ah, thanks for the clarification @attack68, I didn't know our Styler supported exporting to Excel, my bad. I agree with you, we should say in the description why it can make sense to use StyleFrame instead of our styler then. @INDIG0N do you know whay StyleFrame supports that we don't? Or can you research about it? |
Sorry it took me so long to get back to this @datapythonista I've been having trouble finding anything styleframe can do that the pandas styler can't, so at this point I guess we should just close the pull request and the issue. Do you guys know how I can close this PR or is that something that has to be done your end? |
close as requested |
Closes #47525
The issue mentions altering the ecosystem page on the pandas website, do you guys know how I would go about doing that?