Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.There's three divisions in this function that can safely be done at the C-level:
because
nobs
is at least1
when we get here (it starts at0
,nobs+=1
is called a few linesabove, and
nobs
can't decrease), andbecause
divisor
is checked to not be equal to0
in the preceding line.This makes a noticeable difference, example:
On main:
On this branch:
I didn't find much difference in nancorr_spearman, I think because that one calls
the Python function rank_1d within the loop, so that might be a bigger bottleneck there