(WIP) TYP: add some obvious -> None to pandas/core

[MarcoGorelli]

• closes #xxxx (Replace xxxx with the Github issue number)
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

via https://github.com/MarcoGorelli/add-obvious-return-none - adding -> None where possible so at least those functions will be type-checked

there's gonna be a tonne of CI failures so opening as draft for now

[twoertwein]

via https://github.com/MarcoGorelli/add-obvious-return-none - adding -> None where possible so at least those functions will be type-checked

Does this also add None to __init__? Just surprised that no __init__ had missing return annotations :)

Not sure whether it is worth the effort: you could extend your hook to also check pyi files: they have obviously no implementation but at least __init__'s that have no return annotation should probably return None.

If you want to cover non-obvious Nones, you could use pyright: it infers missing return types.

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

[MarcoGorelli]

Closing for now, this'd need some other adjustments first

[twoertwein]

Closing for now, this'd need some other adjustments first

Would be great to have it to close #46337

[MarcoGorelli]

Thanks - I hope to be able to address it soonish

[twoertwein]

Might be great to set up https://github.com/JelleZijlstra/autotyping (I failed to get it running locally)