Skip to content

BUG: read_excel not forward filling index columns when no names are given #47496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Jun 24, 2022

The prevoious has_index_name routine was too simple. This version is aligned with the TextReader version that is used a few lines below

@phofl phofl added the IO Excel read_excel, to_excel label Jun 24, 2022
@mroeschke
Copy link
Member

pandas/io/excel/_base.py:793: error: List item 0 has incompatible type "Union[int, Sequence[int]]"; expected "int"  [list-item]
pandas/io/excel/_base.py:797: error: Argument 1 to "len" has incompatible type "Union[int, Sequence[int], None]"; expected "Sized"  [arg-type]
pandas/io/excel/_base.py:798: error: Argument 1 to "len" has incompatible type "Union[int, Sequence[int], None]"; expected "Sized"  [arg-type]
Found 3 errors in 1 file (checked 1391 source files)

@phofl
Copy link
Member Author

phofl commented Jul 2, 2022

Thx, fixed

@jreback jreback added this to the 1.5 milestone Jul 3, 2022
@jreback jreback merged commit 4fe2f31 into pandas-dev:main Jul 3, 2022
@jreback
Copy link
Contributor

jreback commented Jul 3, 2022

thanks @phofl

@phofl phofl deleted the 47487 branch July 3, 2022 17:10
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: read_excel() doesn't handle Multiindex correctly
3 participants