BUG: Fix issues with numeric_only deprecation #47481
Conversation
rhshadrach
added
Bug
Groupby
Nuisance Columns
pandas/core/groupby/generic.py
Outdated
| warnings.warn( | ||
| f"Passing `numeric_only=True` to {type(self).__name__}.{how} is " | ||
| f"deprecated and will raise in a future version of pandas.", | ||
| category=FutureWarning, | ||
| stacklevel=find_stack_level(), | ||
| ) |
There was a problem hiding this comment.
With the exception of rank, all Series ops fail when passing numeric_only=True (even when the Series is numeric) with a NotImplementedError. However most SeriesGroupBy ops allow it. SerisGroupBy ops will be successful when they can handle object dtype or the dtype is numeric. They will raise an error attempting to perform the op when dtype cannot be operated on.
I'm thinking we should make SeriesGroupBy consistent with Series by raising whenever numreic_only is truthy.
There was a problem hiding this comment.
When I first added the deprecation, I thought other SeriesGroupBy ops would always raise when passing numeric_only=True. Seeing now that's not the case, going to siphon this off into a followup.
The ops std, sem, and quantile all gained the numeric_only argument as part of 1.5.
| method = getattr(gb, groupby_func, None) | ||
|
|
||
| try: | ||
| _ = method(*args) |
There was a problem hiding this comment.
Just to confirm, all groupby_func not expected to fail so that's why try/except is used here and makes it harder to use pytest.raises?
There was a problem hiding this comment.
i.e. can this be tested like
if groupby_func in methods_ok:
method(*args)
elif groupby_func in methods_raise_typeerror:
with pytest.raises(TypeError, ...) as err:
...
elif groupby_func in methods_raise_valueerror:
with pytest.raises(ValueError, ...) as err:
...
There was a problem hiding this comment.
Actually, none are successful. Some would be if the dtype was not object, but I plan to deprecate that in a follow up assuming no objection. Changed over to using pytest.raises.
|
Thanks @rhshadrach |
* BUG: Fix issues with numeric_only deprecation * improve test * Change raising to FutureWarning * revert deprecation * Test improvement
Part of #46560
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.ref: #47265 (comment)
Issues were introduced as part of 1.5, no need for a whatsnew note.