Skip to content

BUG: to_sql with method=callable not returning int raising TypeError #47474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 3, 2022
Merged

BUG: to_sql with method=callable not returning int raising TypeError #47474

merged 7 commits into from
Jul 3, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jun 22, 2022 •
edited
Loading

@mroeschke mroeschke added the IO SQL to_sql, read_sql, read_sql_query label Jun 22, 2022
@simonjayhawkins
Copy link
Member

@mroeschke 1.4.3 is (i think) ready for release first thing tomorrow. I know nothing about sql so not reviewing. If this goes in, I should probably redo some pre-release checks. Not a problem. but would prefer not to have broken ci, broken release note links, manual backports needed etc. etc.. All these sap time waiting for the ci to complete.

@mroeschke
Copy link
Member Author

@mroeschke 1.4.3 is (i think) ready for release first thing tomorrow. I know nothing about sql so not reviewing. If this goes in, I should probably redo some pre-release checks. Not a problem. but would prefer not to have broken ci, broken release note links, manual backports needed etc. etc.. All these sap time waiting for the ci to complete.

No problem. Will push to 1.4.4/1.5

@mroeschke mroeschke added this to the 1.4.4 milestone Jun 23, 2022
@jreback jreback merged commit 2856607 into pandas-dev:main Jul 3, 2022
@jreback
Copy link
Contributor

jreback commented Jul 3, 2022

@meeseeksdev backport 1.4.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jul 3, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jul 3, 2022
@mroeschke @meeseeksmachine
Backport PR pandas-dev#47474: BUG: to_sql with method=callable not re…
68fc092 
…turning int raising TypeError
@lumberbot-app
Copy link

lumberbot-app bot commented Jul 3, 2022

Could not push to auto-backport-of-pr-47474-on-1.4.x due to error, aborting.

simonjayhawkins pushed a commit that referenced this pull request Jul 4, 2022
@meeseeksmachine @mroeschke
Backport PR #47474 on branch 1.4.x (BUG: to_sql with method=callable …
0d96237 
…not returning int raising TypeError) (#47590)

Backport PR #47474: BUG: to_sql with method=callable not returning int raising TypeError

Co-authored-by: Matthew Roeschke <[email protected]>
@mroeschke mroeschke deleted the bug/to_sql_callable_row_count branch July 5, 2022 16:45
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@mroeschke @yehoshuadimarsky
BUG: to_sql with method=callable not returning int raising TypeError (p…
e19647b 
…andas-dev#47474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.

BUG: .to_sql(method=mysql_update_on_dupe_key) fails because of change from 1.3.1 to 1.4.2.
3 participants
@mroeschke @simonjayhawkins @jreback