ENH/TST: Add BaseInterfaceTests tests for ArrowExtensionArray PT2 #47468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
|
Ready for another look @jreback |
jreback
reviewed
Jun 24, 2022
| super().test_setitem_tuple_index(data) | ||
|
|
||
| def test_setitem_slice(self, data, box_in_series, using_array_manager, request): | ||
| tz = getattr(data.dtype.pyarrow_dtype, "tz", None) |
There was a problem hiding this comment.
maybe worth making a helper for this as its happening in virtually every test. (or put it in the fixture) but that's a bit more opaque.
There was a problem hiding this comment.
I can try addressing this in a followup, but it's not perfectly generalizable because some of the tests also fail for a specific unit or sometimes fails for UTC
jreback
reviewed
Jun 24, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #47377 (comment)