ENH/TST: Add BaseInterfaceTests tests for ArrowExtensionArray #47377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Jun 16, 2022
mroeschke
commented
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
mroeschke
added
Testing
mroeschke
commented
Jun 16, 2022
| if TYPE_CHECKING: | ||
| from pandas import Series | ||
|
|
||
| ArrowExtensionArrayT = TypeVar("ArrowExtensionArrayT", bound="ArrowExtensionArray") | ||
|
|
||
|
|
||
| class ArrowExtensionArray(ExtensionArray): | ||
| class ArrowExtensionArray(OpsMixin, ExtensionArray): |
There was a problem hiding this comment.
Should I be using ExtensionOpsMixin or OpsMixin @jbrockmendel?
jreback
reviewed
Jun 17, 2022
| @@ -45,13 +46,22 @@ | |||
| from pandas.core.arrays.arrow._arrow_utils import fallback_performancewarning | |||
| from pandas.core.arrays.arrow.dtype import ArrowDtype | |||
|
|
|||
| ARROW_CMP_FUNCS = { | |||
There was a problem hiding this comment.
isn't there a min version on some of these?
There was a problem hiding this comment.
Looks like they all have been around since pyarrow version 2 which I think is the version we require to use these functions
There was a problem hiding this comment.
Plus we catch the except (pa.lib.ArrowNotImplementedError, pa.lib.ArrowInvalid) when calling these with fallback behavior.
|
ahh merge conflict! |
|
thanks very nice @mroeschke |
|
@mroeschke i've reverted this. can you resubmit. |
5 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
pandas-dev#47462) Revert "ENH/TST: Add BaseInterfaceTests tests for ArrowExtensionArray (pandas-dev#47377)" This reverts commit d40c371.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.