Skip to content

Backport PR #47393 on branch 1.4.x (CI/TST: Don't require length for construct_1d_arraylike_from_scalar cast to float64) #47460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #47393: CI/TST: Don't require length for construct_1d_arraylike_from_scalar cast to float64

…uct_1d_arraylike_from_scalar cast to float64
@lumberbot-app lumberbot-app bot added this to the 1.4.3 milestone Jun 22, 2022
@lumberbot-app lumberbot-app bot added the Compat pandas objects compatability with Numpy or Python functions label Jun 22, 2022
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urgh. Numpy Dev still fails

@simonjayhawkins
Copy link
Member

not yet got down to why this is not failing in main. made the code change anyway for now to see if tests pass.

@simonjayhawkins
Copy link
Member

not yet got down to why this is not failing in main. made the code change anyway for now to see if tests pass.

@mroeschke Numpy Dev is green. waiting on the others. OK to merge or allow time to investigate further? (and fix for 1.4.4 instead). I don't think this is urgent.

@mroeschke
Copy link
Member

not yet got down to why this is not failing in main. made the code change anyway for now to see if tests pass.

@mroeschke Numpy Dev is green. waiting on the others. OK to merge or allow time to investigate further? (and fix for 1.4.4 instead). I don't think this is urgent.

Agreed this is not urgent, but the CI looks "green" (Windows failures appear to the memory errors and the ASV failure is a conda connection error"). So can go in 1.4.3 or 1.4.4

@simonjayhawkins
Copy link
Member

OK let's do for 1.4.3. Since this is numpy-dev related it doesn't affect wheel builds. but the code changes will get exercised by users and if any issues identified could then be resolved in 1.4.4.

@simonjayhawkins simonjayhawkins merged commit 30a3b98 into pandas-dev:1.4.x Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants