Skip to content

Manual Backport PR #47287 on branch 1.4.x (DEPS: Sync environment.yml with CI dep files)" #47453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jun 22, 2022

PR #47287

@simonjayhawkins simonjayhawkins added CI Continuous Integration Dependencies Required and optional dependencies labels Jun 22, 2022
@simonjayhawkins simonjayhawkins added this to the 1.4.3 milestone Jun 22, 2022
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will look soon. nbd if backport misses 1.4.3

(not changed mypy version on backport branch for previous releases).

@simonjayhawkins
Copy link
Member

moving to 1.4.4 as the typing issues on main need sorting too.

@simonjayhawkins simonjayhawkins modified the milestones: 1.4.3, 1.4.4 Jun 22, 2022
@simonjayhawkins
Copy link
Member

@mroeschke the typing failures on 1.4.x I'm also seeing locally with numpy 1.23.1 on main. downgrading to 1.22.4 and mypy checks pass. (So I'm assuming the mypy errors reported on 1.4.x are correct)

With the xarray failure here, I'm not sure what the status of mypy is here. (IIRC you did a PR that run checks even if previous checks failed, we could maybe backport that one)

I'm assuming the environment for the mypy checks on main is incorrect?

I need to understand the issues here and purpose of this more before merging. (As mentioned above, we have tended not to update mypy on the backport branches before and although only a dev dependency, we do list the change in the 1.5 release notes, so updating on 1.4.x could lead to confusion?)

@mroeschke
Copy link
Member Author

This PR just aimed to align the CI changes between main and 1.4.x, namely ensuring all the jobs that utilize environment.yml (all non-testing related checks) include all the dependencies. Looks like in turn this changed typing validations due to bumped versions.

IMO maybe it's not worth back-porting this as it might risk change in behavior in 1.4.x, so closing

@mroeschke mroeschke closed this Jul 18, 2022
@mroeschke mroeschke deleted the auto-backport-of-pr-47287-on-1.4.x branch July 18, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants