TST: GH26650, added new test to validate numpy matmul function with dataframes #47427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carbonleakage
commented
Jun 20, 2022
carbonleakage
commented
- closes Handle numpy.matmul in DataFrame.__array_ufunc__ #26650
- [Tests added and passed]
- All [code checks passed]
phofl
requested changes
Jun 20, 2022
|
Please let the reviewer resolve the conversations |
phofl
reviewed
Jun 20, 2022
pandas/tests/series/test_ufunc.py
Outdated
| # GH26650 | ||
| data = [-1, 1, 10] | ||
| df = pd.DataFrame({"nums": data}) | ||
| dfT = df.T |
There was a problem hiding this comment.
Thanks for reviewing and the feedback. I removed these lines and declared everything directly on the assert statement. Just for my understanding, these lines needed to be removed since they introduce too many variables?
There was a problem hiding this comment.
No, we try to define tests in a way that they do not rely on functions that are not tested itself. E.g. .T was not necessary to reproduce the behavior.
You can do it like:
df=...
result=...
expected=...
arm.assert_frame_equal(result, expected)
There was a problem hiding this comment.
Oh ok, I see. Thanks again! I modified the PR to reflect this.
mroeschke
added
the
Testing
mroeschke
reviewed
Jun 21, 2022
mroeschke
approved these changes
Jun 21, 2022
|
Thanks @carbonleakage |
|
Thanks @mroeschke and @phofl! |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…ataframes (pandas-dev#47427) * TST: GH26650, added new test to validate numpy matmul function with dataframes as inputs * TST: GH26650, updated variable names * Updated based on PR feedback * Removed variable initialisations per feedback * Final updates to PR * Update pandas/tests/series/test_ufunc.py Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.