Skip to content

BUG: DataFrame.setitem raising when rhs is ea dtype Series #47425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Jun 19, 2022

This is a regression on main, so no whatsnew needed.

Is it on purpose, that np_can_hold_element raises when feeding a ea dtype Series as element?

@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Jun 19, 2022
@phofl phofl added this to the 1.5 milestone Jun 19, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @jbrockmendel

@mroeschke mroeschke merged commit 7683563 into pandas-dev:main Jun 24, 2022
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the ea_dtype_rhs branch June 25, 2022 14:23
@jbrockmendel
Copy link
Member

Is it on purpose, that np_can_hold_element raises when feeding a ea dtype Series as element?

I don't think so, no.

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
…v#47425)

* BUG: DataFrame.setitem raising when rhs is ea dtype Series

* Add gh ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants