-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Add tests #47420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add tests #47420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jackgoldsmith4
commented
Jun 19, 2022
- closes BUG: loc behaves incorrectly on PeriodIndex within MultiIndex with 3 levels #24091
- closes Intersection of MultiIndexes reports incorrect lexsort_depth #25169
- All code checks passed.
Hello @jackgoldsmith4! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-06-21 13:48:48 UTC |
91520bc
to
67839df
Compare
@github-actions pre-commit |
phofl
reviewed
Jun 20, 2022
c934254
to
5791417
Compare
mroeschke
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM feel free to merge when ready @phofl
phofl
approved these changes
Jun 21, 2022
thx @jackgoldsmith4 |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* multiindex lexsort depth test * add periodindex loc test * import * pep * Fixes from pre-commit [automated commit] * fix assert * fewer elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.