TYP: ndim is consistently a property #47378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this breaks some tests. |
twoertwein
commented
Jun 25, 2022
| @@ -564,7 +564,7 @@ def test_shift_fill_int_deprecated(self): | |||
|
|
|||
| expected = arr.copy() | |||
| if self.array_cls is PeriodArray: | |||
| fill_val = PeriodArray._scalar_type._from_ordinal(1, freq=arr.freq) | |||
| fill_val = arr._scalar_type._from_ordinal(1, freq=arr.freq) | |||
There was a problem hiding this comment.
This was causing the error: when accessing a property on the class itself, you get the property object, not its content.
mroeschke
approved these changes
Jun 25, 2022
|
Thanks @twoertwein |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TYP: ndim is consistently a property * unused import * fix test * nicer fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and
_scalar_type