BUG: DataFrame.loc not aligning dict when setting to a column #47361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Bug
Indexing
rhshadrach
requested changes
Jun 16, 2022
jreback
reviewed
Jun 24, 2022
| @@ -4709,6 +4709,8 @@ def _sanitize_column(self, value) -> ArrayLike: | |||
| # We should never get here with DataFrame value | |||
| if isinstance(value, Series): | |||
| return _reindex_for_setitem(value, self.index) | |||
| elif isinstance(value, dict): | |||
There was a problem hiding this comment.
I aligned this with a codepath in indexing.py
if (isinstance(value, ABCSeries) and name != "iloc") or isinstance(value, dict):
from pandas import Series
value = self._align_series(indexer, Series(value))
Not sure why we are calling for dict here, but should update in both places when we use is_dict_like here?
There was a problem hiding this comment.
is_dict_like returns True for Series, so it depends if the name != "iloc" is supposed to exclude a specific Series case?
There was a problem hiding this comment.
Ah good point. Yes iloc should not align, hence the condition
There was a problem hiding this comment.
Looks like we end up there with a DataFrame, which raises. Will investigate in follow up how this happens
# Conflicts: # doc/source/whatsnew/v1.5.0.rst
This reverts commit d270851.
mroeschke
approved these changes
Jun 30, 2022
jreback
approved these changes
Jun 30, 2022
|
Thanks @phofl |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…-dev#47361) * BUG: DataFrame.loc not aligning dict when setting to a column * Add partial case * Use is_dict_like * Revert "Use is_dict_like" This reverts commit d270851.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.