Skip to content

CI: Add ccache #47360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 83 commits into from
Closed

CI: Add ccache #47360

wants to merge 83 commits into from
+802 −161

Conversation

jonashaag
Copy link
Contributor

@jonashaag jonashaag commented Jun 15, 2022 •
edited
Loading

Add Sccache https://github.com/mozilla/sccache to the GHA CI. Saves around 5 minutes per run.

Unfortunately it requires some hacks, namely changing a temporary Windows directory and patching distutils.

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jonashaag jonashaag force-pushed the ccache2 branch 2 times, most recently from 256681d to 7d47c23 Compare June 15, 2022 10:42
jonashaag
jonashaag commented Jun 15, 2022
View reviewed changes
@jonashaag jonashaag changed the title WIP CI: Add ccache CI: Add ccache Jun 15, 2022
@jonashaag jonashaag marked this pull request as ready for review June 15, 2022 11:43
@jonashaag jonashaag mentioned this pull request Jun 15, 2022
Closed
6 tasks
mroeschke
mroeschke reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need some documentation on how to manually invalidate the cache. We can potentially get into a bad state like e.g. #47305

@datapythonista datapythonista added the CI Continuous Integration label Jun 16, 2022
@jonashaag
Copy link
Contributor Author

Might need some documentation on how to manually invalidate the cache. We can potentially get into a bad state like e.g. #47305

Done!

@jonashaag jonashaag requested a review from mroeschke June 20, 2022 10:16
@mroeschke
Copy link
Member

While this looks good, the setup.py changes may conflict with #47380 fairly soon. Mind pivoting to other CI improvements (like environment caching) if you have the time until a decision has been made on the linked PR?

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jul 22, 2022
@jbrockmendel
Copy link
Member

Could some of the hacks be avoided by only caching on non-windows?

@jonashaag
Copy link
Contributor Author

Only the TMPDIR one. Actually it might already be unnecessary with the latest version of sccache.

@datapythonista
Copy link
Member

I put this on hold to wait for the Meson changes. Are they done already?

Seems like #49115 is almost ready, maybe a good time to update this?

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Feb 23, 2023
@mroeschke
Copy link
Member

Do you think the sccache-action could be easily be used for this instead? https://github.com/Mozilla-Actions/sccache-action

@jonashaag
Copy link
Contributor Author

This is already using another action. What would be the advantage of switching actions? TBH I think the actions are both very similar

@mroeschke
Copy link
Member

Ah I didn't know if it would make this workflow any simpler, in addition to be more of an official looking ccache action by mozilla

@jonashaag jonashaag mentioned this pull request May 13, 2023
Closed
5 tasks
@mroeschke
Copy link
Member

Closing in favor of #53211

@mroeschke mroeschke closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

Assignees
No one assigned
Labels
CI Continuous Integration Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jonashaag @mroeschke @jbrockmendel @datapythonista @simonjayhawkins @lithomas1