TYP: base_parser and readers #47359
Merged
TYP: base_parser and readers #47359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 15, 2022
| @@ -626,6 +626,21 @@ def get_handle( | |||
| ... | |||
|
|
|||
|
|
|||
| @overload | |||
| def get_handle( | |||
There was a problem hiding this comment.
Just curious, why do we need this overloads when it's the same as the main function typing?
There was a problem hiding this comment.
Mypy and pyright ignore annotations of the implementation when overloads are present (probably the expected behavior based on some PEP). The overloads cover "only" the cases when is_text True or False but not the case when it could be either of them.
The reason I fixed it is that pyright expects the ignore comment at a different line than mypy.
mroeschke
approved these changes
Jun 15, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.