-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH/TST: Add TestBaseDtype tests for ArrowExtensionArray #47358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mroeschke
commented
Jun 15, 2022
•
edited
Loading
edited
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
request.node.add_marker( | ||
pytest.mark.xfail( | ||
raises=NotImplementedError, | ||
reason=f"pyarrow.type_for_alias cannot infer {pa_dtype}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have an issue for followup on these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but I can post an issue on the Arrow JIRA board.
If pyarrow.type_for_alias
decides to implement better parsing, we should get this for free in a future version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm small comment