Skip to content

ENH/TST: Add TestBaseDtype tests for ArrowExtensionArray #47358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 17, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jun 15, 2022

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Arrow pyarrow functionality labels Jun 15, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jun 15, 2022
request.node.add_marker(
pytest.mark.xfail(
raises=NotImplementedError,
reason=f"pyarrow.type_for_alias cannot infer {pa_dtype}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have an issue for followup on these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I can post an issue on the Arrow JIRA board.

If pyarrow.type_for_alias decides to implement better parsing, we should get this for free in a future version

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm small comment

@jreback jreback merged commit 2517b92 into pandas-dev:main Jun 17, 2022
@mroeschke mroeschke deleted the enh/more_arrow_tests branch June 18, 2022 00:21
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants