TST: adding a test for bar plot with intervalrange xaxis

[noatamir]

• closes REGR: Bar plot from Series with IntervalIndex fails in pandas 1.2.0 #38969
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.

[noatamir]

The smoke test LGTM
The assert is giving me a weird error locally, maybe you can give me some advice here:
The two lists appear to be identical yet I get this error:

E       AssertionError: assert [Text(0, 0, '([0, 1],)'), Text(1, 0, '([1, 2],)')] == [Text(0, 0, '([0, 1],)'), Text(1, 0, '([1, 2],)')]
E         At index 0 diff: Text(0, 0, '([0, 1],)') != Text(0, 0, '([0, 1],)')
E         Full diff:
E           [Text(0, 0, '([0, 1],)'), Text(1, 0, '([1, 2],)')]

[noatamir]

I have a fix coming up! ✨

[noatamir]

OK, I think this is ready now.

I also opened an issue with Matplotlib to add eq to the Text object in the hope that writing these tests would be easier in the future 😇

[phofl]

looks good, couple of small comments

[phofl]

We normally don't add these comments, when an issue is linked.

I don't know matplotlib very well, but can we import this at the top?

[noatamir]

Looks like we can. I will go ahead and clean it from the other 2 tests that import it.

Huh, do you mean the 2nd line comment? I noticed that most tests in this Misc file do this. But I really don't mind deleting it...

[phofl]

Thx.

Oh interesting. I am not really familiar with our plotting code-base. We try to avoid most comments in tests in other places. I think you can keep it in, if it is consistent with the rest though.

[phofl]

I also opened an issue with Matplotlib to add eq to the Text object in the hope that writing these tests would be easier in the future 😇

this would be really nice!

[noatamir]

See matplotlib/matplotlib#23273 for follow up ✨

[noatamir]

@phofl I'm getting this error on the CI now:

/opt/python/cp38-cp38/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
pandas/tests/plotting/test_misc.py:3: in <module>
    from matplotlib.text import Text
E   ModuleNotFoundError: No module named 'matplotlib'

Might be because I moved the import up? Any suggestions on how to proceed? revert or what's the underlying cause to address?

[phofl]

Ah this makes sense. Looks like we are not installing matplotlib everywhere. Reverting is the best way forward here, this explains why the imports were done within the tests.

Thanks for trying this out

[mroeschke]

LGTM. Merge when ready @phofl

[phofl]

thx @noatamir