ENH: Move UndefinedVariableError to error/__init__.py per GH27656 #47338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Enhancement
Error Reporting
mroeschke
reviewed
Jun 13, 2022
| @@ -495,7 +495,7 @@ def test_query_syntax_error(self): | |||
| df.query("i - +", engine=engine, parser=parser) | |||
|
|
|||
| def test_query_scope(self): | |||
| from pandas.core.computation.ops import UndefinedVariableError | |||
There was a problem hiding this comment.
These imports might be able to be moved to the top (in a follow up PR would be okay)
mroeschke
approved these changes
Jun 13, 2022
|
Thanks again! |
5 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.5.0.rstfile if fixing a bug or adding a new feature.I made a tweak to scripts/pandas_errors_documented.py because it was flagging the
annotationsimport not being in the testing.rst. I excluded future module from the documentation check because the script's intent seems to be ensuring the custom pandas errors are documented. I also fixed a typo.