BUG: assert_index_equal ignoring names when check_order is false #47330
Conversation
phofl
added
Bug
Testing
pandas/core/indexes/api.py
Outdated
| ) | ||
| else: | ||
| index = Index(array_sorted, name=index.name, dtype=index.dtype) | ||
| except TypeError: |
There was a problem hiding this comment.
maybe only have the safe_sort call in the try block?
There was a problem hiding this comment.
A bit tricky, since array_sorted does not exist in the except block and we don't want to caste the Index again to an Index?
There was a problem hiding this comment.
with an else block we would only cast if the safe_sort succeeded? (i.e. Index values are unique)
There was a problem hiding this comment.
Thanks very much. I am always forgetting that...
Changed the code
doc/source/whatsnew/v1.5.0.rst
Outdated
| @@ -935,7 +935,7 @@ Other | |||
|
|
|||
| .. ***DO NOT USE THIS SECTION*** | |||
|
|
|||
| - | |||
| - Bug in :func:`.assert_index_equal` with ``names=True`` and ``check_order=False`` not checking names not (:issue:`47328`) | |||
There was a problem hiding this comment.
DO NOT USE THIS SECTION
yep. this is ok here, in previous release notes the assert_* always go in the other section.
There was a problem hiding this comment.
checked 1.3 notes to be sure there
Co-authored-by: Simon Hawkins <[email protected]>
| ------- | ||
| Index | ||
| """ | ||
| try: |
There was a problem hiding this comment.
following on from #47329 (comment)
is our use of safe_sort here, actually safe? i.e. we don't reach any of the cases that raise in safe_sort) and the try is not needed?
There was a problem hiding this comment.
None inside a mixed index still raises a TypeError
There was a problem hiding this comment.
This gets adressed in #47331, we can probably remove the try there
# Conflicts: # pandas/_testing/asserters.py
|
Resolved conflicts |
|
Thanks @phofl |
…das-dev#47330) * BUG: assert_index_equal ignoring names when check_order is false * Update doc/source/whatsnew/v1.5.0.rst Co-authored-by: Simon Hawkins <[email protected]> * Move index creation to else block * Remove dtypes Co-authored-by: Simon Hawkins <[email protected]>
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This should get merged after #47325 (will probably have a conflict then)