-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: pd.DataFrame.from_records() raises a KeyError if passed a string index and an empty iterable #47319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Kelvingandhi
wants to merge
10
commits into
pandas-dev:main
from
Kelvingandhi:bug/47285_from_records_key_error
Closed
BUG: pd.DataFrame.from_records() raises a KeyError if passed a string index and an empty iterable #47319
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8c273a1
fix bug in dataframe.from_records with str index and empty iterable i…
Kelvingandhi 48960d4
fix bug in dataframe.from_records method with str index and empty ite…
Kelvingandhi 149bb59
fix blank lines PEP 8 issue in test_info.py
Kelvingandhi cb91d1d
fix behavior on iterable with data and wrong index to raise the KeyEr…
Kelvingandhi a87ef23
fix behavior on iterable with data and wrong index to raise the KeyEr…
Kelvingandhi 17b4efc
Fixes from pre-commit [automated commit]
Kelvingandhi 1651372
Update doc/source/whatsnew/v1.5.0.rst
simonjayhawkins 2b4b0d4
fix tests with suggestions and typos in doc
Kelvingandhi 8337706
Split test cases and fixed pre-commit failure
Kelvingandhi 0abc57a
Fixed Typing Validation Error in frame.py
Kelvingandhi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the test we discussed where the behavior changed initially?
Also pre-commit is failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After our discussion, I fixed that issue and also added that test in test_info.py (please check lines 502-509) plus in that test case, I made correction as well suggested by @simonjayhawkins (#47319 (comment)).
Furthermore, I already have initial test case included as well (lines 498-500).
I'm unsure what else is required.
On pre-commit failure, I'm beginner here and not sure what causing it to fail (when last time it passed for earlier commits). Any help to get this resolved would be appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, missed that. Could you split that into two tests? Since technically they are testing different things.
You can run pre-commit locally and check the log. This should show the errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I will do that. Thank you for the response.