Skip to content

ENH: Timestamp.normalize support non-nano #47316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2022
Merged

ENH: Timestamp.normalize support non-nano #47316

merged 2 commits into from
Jun 13, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel jbrockmendel mentioned this pull request Jun 12, 2022
Merged
5 tasks
mroeschke
mroeschke reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also minor, I noticed some of the typings in the cython code for timezones are e.g. tzinfo tz when it looks like it should be tzinfo | None tz like in _from_value_and_reso.

@jbrockmendel
Copy link
Member Author

Also minor, I noticed some of the typings in the cython code for timezones are e.g. tzinfo tz when it looks like it should be tzinfo | None tz like in _from_value_and_reso.

good catch, will edit in an upcoming PR

@mroeschke mroeschke added Datetime Datetime data dtype Non-Nano datetime64/timedelta64 with non-nanosecond resolution labels Jun 13, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jun 13, 2022
@mroeschke mroeschke merged commit 28d5b01 into pandas-dev:main Jun 13, 2022
@jbrockmendel jbrockmendel deleted the nano-normalize branch June 13, 2022 19:25
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
ENH: Timestamp.normalize support non-nano (pandas-dev#47316)
ff3b643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Non-Nano datetime64/timedelta64 with non-nanosecond resolution
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke