Use setup-conda action #47293
Use setup-conda action #47293
Conversation
| use-only-tar-bz2: true | ||
| condarc-file: ci/condarc.yml | ||
| - name: Set up Conda | ||
| uses: ./.github/actions/setup-conda |
There was a problem hiding this comment.
Nit: Could we rename this actions setup_conda to match build_pandas?
There was a problem hiding this comment.
The GHA convention seems to be kebab-case, see eg. https://github.com/conda-incubator/setup-miniconda/blob/main/action.yml#L23
I think we should stick to one style everywhere (action names, inputs, ...). Please make a decision if we want snake_case or kebab-case.
There was a problem hiding this comment.
Okay happy to change build_pandas to build-pandas then (feel free to change this in one of your other PRs)
There was a problem hiding this comment.
LGTM. Do you think it also makes sense to add the caching of conda packages to this step too?
- name: Cache conda
uses: actions/cache@v3
env:
CACHE_NUMBER: 0
with:
path: ~/conda_pkgs_dir
key: ${{ runner.os }}-conda-${{ env.CACHE_NUMBER }}-${{
hashFiles('${{ env.ENV_FILE }}') }}
|
Will send more PRs with caching changes soon :) The current caching is broken/badly implemented |
|
Thanks @jonashaag, looking forward to the followups :) |
* Use setup-conda action * Update action.yml * Update posix.yml * Update sdist.yml * Update sdist.yml * Update sdist.yml * Update action.yml
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.