-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPS: Sync environment.yml with CI dep files #47287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
be93a78
DEPS: Sync environment.yml with CI dep files
mroeschke acb1a9d
Run job to check that requirements-dev.txt installable
mroeschke 3e8ce0e
Update python version
mroeschke bcaf4b1
Rename posix to ubuntu
mroeschke 25fa9d7
Just test on 3.8
mroeschke 8d1a63f
pip mapping or geopandas
mroeschke f7afb62
Adjust requirements.txt
mroeschke 0005a3b
Address code check job and torch
mroeschke ce7b55e
Bump numexpr
mroeschke 3cd37c3
Lower bound numba
mroeschke d094c4f
Merge remote-tracking branch 'upstream/main' into clean/environment_yml
mroeschke 83052c1
Merge remote-tracking branch 'upstream/main' into clean/environment_yml
mroeschke 9461d8d
Remove type ignores
mroeschke d042920
Merge remote-tracking branch 'upstream/main' into clean/environment_yml
mroeschke 4c4ee45
Merge remote-tracking branch 'upstream/main' into clean/environment_yml
mroeschke f67e3d3
Address more typing
mroeschke 79779f3
Fix if statement
mroeschke 194285f
Fix typing errors
mroeschke 1be3b48
Fix typo
mroeschke edf6190
Merge remote-tracking branch 'upstream/main' into clean/environment_yml
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could cause installing an older numpy version which could(?) explain most of the errors (but not the pyqt stuff).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is one dedicated CI run for numpy-dev, it would make sense to use the latest numpy compatible with numba (even for typing). Reverting #45244 would probably fix most of the numpy errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should only affect our specific PY 3.10 build which just runs the unit tests though. The typing checks should have an environment that is set up by
environment.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant that since we anyways run the unit tests with NumPy-dev in a separate workflow, prioritizing the latest numba version over the latest (released) NumPy version (in
environment.yml
) could be fine. Either way, it would be good to limit the numba version or the numpy version inenvironment.yml
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem I have with this is that new contribritors when setting up an environment will get the latest numpy and have mypy errors by default.
We should make the contributor experience pain free so (imo) we should use environment.yaml for the typing validation to match the local dev env .
Otherwise, this just makes it difficult for people to contribute to the typing issues.
Now, numba is included in environment.yaml so I'm not sure why when I set up a clean dev locally I get numpy 1.23.1 and on ci we get 1.22.4 (maybe there is some caching on ci?)
My comments here are from looking into this a couple of weeks ago. So this comment here now maybe out of date. Will look again soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit that I don't use the official way to setup a pandas-dev env, but it would be great to ensure that the officially documented pandas-env does not cause mypy errors.
Maybe numba has different numpy-constraints on conda-forge (or conda installs incompatible versions)? When I ask poetry to install
numba = ">=0.53.1"
(as in environment.yml) andnumpy = ">=1.23.0"
, it is unable to find a solution (at least not on Linux with python 3.10).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I need to double check that's still true.