Error raised message: DataFrame eval will not work with 'Timestamp' column name #47273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 2, 2022 23:15
weikhor
changed the title
phofl
reviewed
Jun 7, 2022
jreback
requested changes
Jun 10, 2022
There was a problem hiding this comment.
https://github.com/pandas-dev/pandas/blob/main/pandas/core/computation/scope.py#L56
we explicitly set this. as an injected global. i am not sure what you could do there but i agree with @phofl that we would like to allow this
added 4 commits
June 11, 2022 18:57
added 7 commits
June 16, 2022 23:39
mroeschke
reviewed
Jul 12, 2022
mroeschke
reviewed
Jul 26, 2022
mroeschke
reviewed
Jul 26, 2022
| def test_eval_no_support_column_name(request, column): | ||
| # GH#44603 | ||
| if column in ["True", "False", "inf", "Inf"]: | ||
| request.node.add_marker(pytest.mark.xfail(raises=KeyError)) |
There was a problem hiding this comment.
Could you add a reason here (with a f-string with the column value)?
added 3 commits
July 31, 2022 01:19
mroeschke
approved these changes
Aug 1, 2022
jreback
requested changes
Aug 2, 2022
added 2 commits
August 5, 2022 00:44
Have added a whatsnew entry (for 1.5, conversion bug fix section) |
mroeschke
reviewed
Aug 8, 2022
mroeschke
reviewed
Aug 8, 2022
mroeschke
approved these changes
Aug 10, 2022
jreback
approved these changes
Aug 12, 2022
|
thanks @weikhor this is great! |
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.