Skip to content

add test to check type of df column after loc() #47264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 13, 2022
Merged

add test to check type of df column after loc() #47264

merged 5 commits into from
Jun 13, 2022

Conversation

jackgoldsmith4
Copy link
Contributor

@jackgoldsmith4 jackgoldsmith4 commented Jun 7, 2022 •
edited
Loading

@jackgoldsmith4
Copy link
Contributor Author

Hey @mroeschke, I'd like to start writing tests for a lot of the existing GH issues. I am learning as I go, so I am not sure if something like this is sufficient and/or in the right place. Any critical feedback would be greatly appreciated so I can start writing better and more complex tests. Thanks!

@mroeschke
Copy link
Member

Awesome! Definitely check out https://pandas.pydata.org/docs/dev/development/contributing_codebase.html#using-pytest for all the details of how tests ideally should be structured and what should be included

@pep8speaks
Copy link

pep8speaks commented Jun 10, 2022 •
edited
Loading

Hello @jackgoldsmith4! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-06-12 18:18:15 UTC

@jackgoldsmith4 jackgoldsmith4 requested a review from mroeschke June 12, 2022 19:35
@mroeschke mroeschke added this to the 1.5 milestone Jun 13, 2022
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Jun 13, 2022
@mroeschke mroeschke merged commit 5465f54 into pandas-dev:main Jun 13, 2022
@mroeschke
Copy link
Member

Thanks @jackgoldsmith4

@jackgoldsmith4 jackgoldsmith4 deleted the loc-test branch June 13, 2022 00:24
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jackgoldsmith4 @yehoshuadimarsky
add test to check type of df column after loc() (pandas-dev#47264)
019e51a 
* add test

* double quotes

* fixes

* remove pd

* fix index type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

Data type of new assigned DataFrame column
3 participants
@jackgoldsmith4 @mroeschke @pep8speaks