Skip to content

ENH: Add check_like functionality to assert_series_equal #47248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stevenschaerer
Copy link
Contributor

@stevenschaerer stevenschaerer commented Jun 5, 2022

@pep8speaks
Copy link

pep8speaks commented Jun 5, 2022

Hello @stevenschaerer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-06-07 08:16:34 UTC

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fairly good. Just a comment about version documentation

@mroeschke mroeschke added Enhancement Testing pandas testing functions or related to the test suite labels Jun 6, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jun 6, 2022
@mroeschke mroeschke merged commit 46eac3a into pandas-dev:main Jun 7, 2022
@mroeschke
Copy link
Member

Awesome, thanks @stevenschaerer

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
…47248)

* Add check_like functionality to assert_series_equal

* fix code formatting issues

* versionadded and whatsnew

* fix test comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: check_like for assert_series_equal
3 participants