ENH: preserve non-nano DTA/TDA in Index/Series/DataFrame #47230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks really cool. Not sure if for the tests I'd compare to the literal of the dtype we expect. We're testing that the type of the array are preserved. This could be tested in general (not sure if it is), but feels a bit strange that this is done in the tests specific to non-nano, instead of making sure the dtype is the non-nano we want. Not important, just sharing, if you like this approach better, is fine with me. I guess we're testing the dtype of the array elsewhere already. |
jreback
reviewed
Jun 5, 2022
| @@ -537,15 +537,16 @@ def treat_as_nested(data) -> bool: | |||
| # --------------------------------------------------------------------- | |||
|
|
|||
|
|
|||
| def _prep_ndarray(values, copy: bool = True) -> np.ndarray: | |||
| def _prep_ndarray( | |||
There was a problem hiding this comment.
maybe rename to prep_array_like or similar?
mroeschke
reviewed
Jun 14, 2022
mroeschke
approved these changes
Jun 15, 2022
|
Thanks @jbrockmendel |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…47230) * ENH: preserve non-nano DTA/TDA in Index/Series/DataFrame * tighten xfail * _prep_ndarray->_prep_ndarraylike * xfail non-strict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue to cast non-nano ndarrays, but if a user goes out of there way to create a non-nano DTA/TDA, preserve it in the other constructors.