ENH: Move SettingWithCopyWarning to error/__init__.py per GH27656 #47198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 2, 2022
pandas/errors/__init__.py
Outdated
| This can happen unintentionally when chained indexing. | ||
|
|
||
| For more information, see 'Evaluation order matters' on | ||
| https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html |
There was a problem hiding this comment.
Could you use sphinx referencing here like
For more information, see :ref:`the user guide<indexing.evaluation_order>`
You can check indexing.rst for the .. _indexing.evaluation_order sphinx references for each section.
There was a problem hiding this comment.
Ah, I didn't know about that; thank you for the comment! I've updated the references
mroeschke
approved these changes
Jun 3, 2022
|
Thanks again @dataxerik. Great progress on this issue |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…ndas-dev#47198) * ENH: Move SettingWithCopyWarning to error/__init__.py per GH27656 * ENH: change links to sphinx ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.5.0.rstfile if fixing a bug or adding a new feature.