Skip to content

TYP: NDFrame.min/max mypy workaround #47197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2022
Merged

TYP: NDFrame.min/max mypy workaround #47197

merged 1 commit into from
Jun 2, 2022

Conversation

twoertwein
Copy link
Member

mypy infers _max_examples as string when I use reveal_type but without an explicit type annotation, mypy weirdly thinks that the decorated is untyped.

@mroeschke mroeschke added this to the 1.5 milestone Jun 2, 2022
@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Jun 2, 2022
@mroeschke mroeschke merged commit 452064d into pandas-dev:main Jun 2, 2022
@mroeschke
Copy link
Member

Thanks @twoertwein

@twoertwein twoertwein deleted the minmax branch June 8, 2022 19:26
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@twoertwein @yehoshuadimarsky
TYP: NDFrame.min/max mypy workaround (pandas-dev#47197)
338fd56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@twoertwein @mroeschke