ENH: Better rename/set_names handling for Index #4718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MultiIndex now responds correctly to ``rename`` (synonym for ``set_names``) * ``set_names`` checks that input is list like. * Cleaner error message for immutable ops. * Added in previously missing tests for MultiIndex immutable metadata. * Altered ``is_list_like`` to check for binary_types as well.
|
@jreback any comments? |
|
looks good to me |
jtratner
added a commit
that referenced
this pull request
Sep 1, 2013
ENH: Better rename/set_names handling for Index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4628
rename(synonym forset_names)set_nameschecks that input is list like.is_list_liketo check for binary_types as well.For now, this is the behavior for Index.rename. It's simple and clear and lets existing code just work instead of dealing with typechecks: