Skip to content

CI: Versioneer not picking up version in 32-bit build #47179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2022
Merged

CI: Versioneer not picking up version in 32-bit build #47179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84bd82f
CI: Versioneer not picking up version in 32-bit build
lithomas1 May 30, 2022
53a6a4d
Merge branch 'main' into fix-versions-32bit
lithomas1 May 31, 2022
1f8fdf4
code checks
lithomas1 May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/32-bit-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,15 @@ jobs:

- name: Run 32-bit manylinux2014 Docker Build / Tests
run: |
# Without this (line 34), versioneer will not be able to determine the pandas version.
# This is because of a security update to git that blocks it from reading the config folder if
# it is not owned by the current user. We hit this since the "mounted" folder is not hit by the
# Docker container.
# xref https://github.com/pypa/manylinux/issues/1309
docker pull quay.io/pypa/manylinux2014_i686
docker run --platform linux/386 -v $(pwd):/pandas quay.io/pypa/manylinux2014_i686 \
/bin/bash -xc "cd pandas && \
git config --global --add safe.directory /pandas && \
/opt/python/cp38-cp38/bin/python -m venv ~/virtualenvs/pandas-dev && \
. ~/virtualenvs/pandas-dev/bin/activate && \
python -m pip install --no-deps -U pip wheel 'setuptools<60.0.0' && \
Expand Down
8 changes: 0 additions & 8 deletions pandas/tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@
import numpy as np
import pytest

from pandas.compat import (
IS64,
is_ci_environment,
)

import pandas as pd
from pandas import Series
import pandas._testing as tm
Expand Down Expand Up @@ -162,9 +157,6 @@ def test_standardize_mapping():
assert isinstance(com.standardize_mapping(dd), partial)


@pytest.mark.xfail(
is_ci_environment() and not IS64, reason="Failing on 32 bit Python CI job"
)
def test_git_version():
# GH 21295
git_version = pd.__git_version__
Expand Down
7 changes: 0 additions & 7 deletions pandas/tests/util/test_show_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@

import pytest

from pandas.compat import (
IS64,
is_ci_environment,
)
from pandas.util._print_versions import (
_get_dependency_info,
_get_sys_info,
Expand Down Expand Up @@ -73,9 +69,6 @@ def test_show_versions_console_json(capsys):
assert result == expected


@pytest.mark.xfail(
is_ci_environment() and not IS64, reason="Failing on 32 bit Python CI job"
)
def test_show_versions_console(capsys):
# gh-32041
# gh-32041
Expand Down